Disable CSP when in debug mode. #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? |
|
Eruda needs to run a remote script to work, otherwise just setting LEMMY_UI_DEBUG won't work on its own. |
|
Ah but LEMMY_UI_DEBUG wont be set automatically when you just run yarn start, right? In that case its fine, but the name is confusing. I would change it to LEMMY_UI_ERUDE_DEBUG. |
|
Correct, you still need to set that one env var now. It should pry stay as just |
Nutomic
force-pushed
the
smartert_disable_csp
branch
from
a493a7f to
263c859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.